Skip to content

Conversation

ryanthecoder
Copy link
Contributor

Overview

This finalizes the QC upgrade to a protocol, it also adjusts some of the liquid class values so that they match the ones from the previous production script.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested review from a team as code owners August 6, 2025 18:51
@ryanthecoder ryanthecoder requested review from jerader and removed request for a team August 6, 2025 18:51
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.50%. Comparing base (95b9d6e) to head (ea3bb8a).
⚠️ Report is 9 commits behind head on chore_release-8.6.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-8.6.0   #19141      +/-   ##
=======================================================
- Coverage                24.00%   21.50%   -2.51%     
=======================================================
  Files                     3377     3040     -337     
  Lines                   296968   240440   -56528     
  Branches                 31523     9340   -22183     
=======================================================
- Hits                     71301    51702   -19599     
+ Misses                  225649   188738   -36911     
+ Partials                    18        0      -18     
Flag Coverage Δ
app ?
components ?
hardware ?
labware-library ?
opentrons-ai-client ?
protocol-designer 18.92% <ø> (ø)
react-api-client ?
shared-data ?
step-generation 5.37% <ø> (ø)
system-server ?
update-server ?
usb-bridge ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2054 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryanthecoder ryanthecoder force-pushed the EXEC-1370-pt4 branch 2 times, most recently from c52b33c to f8a90f6 Compare August 7, 2025 16:32
@ryanthecoder ryanthecoder added the gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails label Aug 7, 2025
Copy link
Contributor

github-actions bot commented Aug 7, 2025

A PR has been opened to address analyses snapshot changes. Please review the changes here: #19154

ryanthecoder added a commit that referenced this pull request Aug 7, 2025
This PR was requested on the PR
#19141

Co-authored-by: ryanthecoder <[email protected]>
@ryanthecoder ryanthecoder changed the base branch from edge to chore_release-8.6.0 August 8, 2025 19:19
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, thank you!

@ryanthecoder ryanthecoder merged commit 0f9d1a4 into chore_release-8.6.0 Aug 11, 2025
96 checks passed
neo-jesse pushed a commit that referenced this pull request Aug 19, 2025
…tocol. (#19141)

<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:


https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:


https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

# Overview
This finalizes the QC upgrade to a protocol, it also adjusts some of the
liquid class values so that they match the ones from the previous
production script.

<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

## Test Plan and Hands on Testing

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

## Changelog

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

## Review requests

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

## Risk assessment

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->

---------

Co-authored-by: wweiye <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ryanthecoder <[email protected]>
sfoster1 added a commit that referenced this pull request Aug 21, 2025
These are good changes that are correct, but they are significant
behavior changes that must be separated by a new liquid class version.
They cannot retroactively change the V1 liquid class.

This was generated by running `git checkout
679ccd8 -- shared-data/liquid-class/`
which should give us the liquid classes as of
679ccd8
, the final commit before the problematic one.

The rest of #19141 is
unchanged.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: sfoster1 <[email protected]>
ddcc4 added a commit that referenced this pull request Sep 5, 2025
# Overview

Now that we have versioning support in `get_liquid_class()` (PR #19408),
this PR takes the updated liquid class values for `water` (PR #19141)
and makes them available as version 2 of the `water` class. AUTH-2246

This PR also makes the preliminary values for the low-volume 96
`flex_96channel_200` pipette available in `water` v2, so that they can
be used by hardware testing. If we decide that we don't want to release
`flex_96channel_200` in the public RS 8.6.1 release, we'll delete the
`flex_96channel_200` values again.

And this fixes the `test_gravimetric_protocol.py` test to stop failing.
It's been failing since PR #19306 when we deleted the
`flex_96channel_200` liquid class values from RS 8.6.0.

## Test Plan and Hands on Testing

Ran the updated `test_gravimetric_protocol.py` and confirmed that it
passes.

Confirmed that `test_protocol_core.py` still passes.

## Risk assessment

Low. But remember to remove the `flex_96channel_200` values from `water`
v2 if we don't want to release them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gen-analyses-snapshot-pr Generate a healing PR if the analyses snapshot test fails
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants